VIDEO-4475- Adding isSupported error modal

PikaJoyce commented 3 years ago

I've added a bootstrap modal to display whenever chrome is not the browser in use.

Here is the modal on Safari :

on Firefox :

I was originally using Video.isSupported but since we support multiple browsers on the SDK, and we only support chrome for video-processors, I am using window.chrome to do this check. However, this works on Microsoft Edge.

Contributing to Twilio

All third party contributors acknowledge that any contributions they provide will be made under the same open source license that the open source project is provided under.

[x] I acknowledge that all my contributions will be made under the project's license.

Pull Request Details

Description

A description of what this PR does.

Burndown

Before review

[ ] Updated CHANGELOG.md if necessary
[ ] Added unit tests if necessary
[ ] Updated affected documentation
[x] Verified locally with npm test
[ ] Manually sanity tested running locally
[x] Included screenshot as PR comment (if needed)
[ ] Ready for review

charliesantos commented 3 years ago

Hey @PikaJoyce , sorry if it wasn't clear, but we want to add the isSupported flag in the SDK so that you can do something like

import { isSupported } from '@twilio/video-processors-sdk';

Then use that flag in your example app.

The isSupported flag should return true if OffscreenCanvas is available and you are not running on a mobile device. We should also add unit tests for this flag.

PikaJoyce commented 3 years ago

Going to close this for now :D

twilio / twilio-video-processors.js