search

twilio / twilio-video-processors.js

Twilio Video Processors is a collection of video processing tools which can be used with Twilio Video JavaScript SDK to apply transformations and filters to a video track.
Other
33 stars 21 forks source link

Avoid to load model multiple times #26

Closed Takeno closed 2 years ago

Takeno commented 3 years ago

Currently, everytime you call AnyProcessor.loadModel() it makes 3 ajax calls to load assets, even if they are already loaded.

Before opening a PR, I would like to discuss with you if it can be useful to avoid to load models multiple times for the same configuration.

The idea is to changes this: processors/background/BackgroundProcessor.ts#L105 with a sort of memoization based on config.

The expected result is more efficient activation of the processor after the first time.

manjeshbhargav commented 3 years ago

Hi @Takeno ,

Thanks for writing in with this question. We have a plan to work on this as part of a future release. Please watch this space for updates.

vbabenko commented 2 years ago

Hi there, Any updates here?

manjeshbhargav commented 2 years ago

Hi @vbabenko ,

We are planning to take this up at the beginning of next year. Please watch this space for updates.

charliesantos commented 2 years ago

We fixed this and it's scheduled to release soon. Please watch this space for updates.