search

twilio / twilio-video-processors.js

Twilio Video Processors is a collection of video processing tools which can be used with Twilio Video JavaScript SDK to apply transformations and filters to a video track.
Other
33 stars 21 forks source link

Firefox 105 support #49

Closed lukewarlow closed 1 year ago

lukewarlow commented 1 year ago

What is the feature that you would like to see? Please describe. Firefox 105 which is due for release September 20th comes with Offscreen Canvas support. I believe I'm correct in thinking that's the last API required from Firefox for support. If so it would be good if the browser supported check could be updated to account for this.

Is your feature request related to a problem? Please describe. Being able to offer virtual background functionality to Firefox users as well as Chromium would be good.

Dosant commented 1 year ago

Thumbs up!

I've tried to test this out in firefox with the recent twilio video js version (2.24.x), by just removing the browser check didn't work.

I got the ns_error_not_initialized initialized error here. I found this thread where was suggested to call canvas.getContext('2d'); before starting capturing the stream. This fixed the error, but then, in my case, I just got the frozen frame (with a properly applied background filter) and the video wasn't running. So I guess more investigation and works needs to be done.

I then was wondering why the demo works in firefox and realized that it was using 2.0.0-rc1 that I didn't know exist.
But Seems like there was no activity for a while ;(

Dear Twilio team, could you please let us know the status of 2.0.0-rc1 branch? Is there any chance it will be finished or was the project abandoned?

ravkoopharma commented 1 year ago

Recently we have implemented Virtual Background feature in our Web App, it's working great with Google Chrome, Brave Browser but it's not working with Firefox. Our front end is developed with Angular 11 we are using twilio-video - ^2.26.1 version and video-processors - ^1.0.2. AS @Dosant mentioned the demo working fine in Firefox.

Can anyone help me with that is there anything we are missing. We have followed same instruction and code which is mentioned in demo and tutorials.

Thanks in Advance.

lukewarlow commented 1 year ago

Version 2 should address this so closing