twilio / twilio-video.js

Twilio’s Programmable Video JavaScript SDK
https://www.twilio.com/docs/video/javascript
Other
571 stars 217 forks source link

During simulcast conference if two participants publish video at the same time the tab crashes in Chrome #319

Closed anand-io closed 4 years ago

anand-io commented 6 years ago

Code to reproduce the issue:

https://github.com/anand-io/video-quickstart-js

Expected behavior:

Should not crash

Actual behavior: Chrome crashed

Steps to reproduce: 1) Clone modified video-quickstart-js in which I changed the "Preview my camera" button to "Toggle my camera" to attach a video track in-between the call, also turned on "simulcast". 2) You need two people/machine to replicate this issue so use ngrok/server. 3) Both participants join the same room 4) Both participants turn on the camera almost at the same time or a one sec delay. 5) one side it should crash(the one that gets "Glare detected; rolling back")

Note: Happening only for simulcast conference.

Video sample: https://cl.ly/1U1I2r1v3t3a https://cl.ly/271H3v0J0I32 https://cl.ly/0K0w2M1X3i2M

The crash happens only when this I see this log - "Glare detected; rolling back"

Software versions:

markandrus commented 6 years ago

@anand-io thanks very much—we'll dig into this and file a bug. My guess is it is a change in behavior in Chrome.

anand-io commented 6 years ago

I gotta give you more info. This has been happening since the simulcast release in twilio-video. I didn't get time to replicate that in quick start app and create an issue here that time. So I don't think this is recent chrome issue.

markandrus commented 6 years ago

@anand-io we have fixes for this issue slated to land in 1.12.0: