twilio / twilio-voice-ios

Programmable Voice SDK by Twilio
https://www.twilio.com/voice
38 stars 14 forks source link

Multiple leaks from TwilioVoice. #124

Closed makaveli9727 closed 6 months ago

makaveli9727 commented 9 months ago

Description

There are at least 9 leaks produced by TwilioVoice SDK in our app. I already tried profiling a quickstart repository and updated TwilioVoice SDK to v6.10.1 and those leaks persist there as well. You can replicate the process independently by utilizing Instruments.app and conducting a profile analysis on the Quickstart.

Steps to Reproduce

  1. Profile on iOS 15+ versions.
  2. After Profiling finish, choose a template "Leaks" and record leaks by pressing "Start an immediate mode recording"
  3. 9 leaks appear right after 5-7 seconds.

Providing a screenshot of a recorded .trace file:

Leaks

You can clearly see from the screenshot above which library is responsible for those leaks.

Reproduces How Often

100%

Voice iOS SDK

v6.10.1 via SPM

Xcode

v15.2

iOS Version

iOS 15, 16, 17, 17+

iOS Device

Any

dipankadas commented 8 months ago

@makaveli9727 The leaks are coming from a third party library that we use for SIP signaling. We will see if anything can be done in the third party lib to fix the issue but that might take a while.

dipankadas commented 6 months ago

This is not a high priority now. We will take up this work when we upgrade the third party library. Closing this now we will create internal ticket for this issue to track