search

twilio / twilio-voice-notification-app

Reference app built in ReactJS that demonstrates how to leverage Twilio Programmable Voice and Twilio SDKs to create a voice notification system.
Apache License 2.0
36 stars 26 forks source link

Heroku Deploy Build - Invalid numbers alert after uploading for valid phone numbers in text file. Numbers are valid. #53

Open jefftcarroll opened 3 years ago

jefftcarroll commented 3 years ago

After deploying the client via Heroku, for a simple text file consisting of U.S. numbers in the following format (numbers hidden for privacy) in a TXT file, I receive Alert messages marking all numbers as invalid. Geographic permissions are set correctly.

+1########## +1##########

ricardotwilio commented 3 years ago

Hello @jefftcarroll, I am sorry you are having issues creating a notification.

We have updated the code today resolving some security vulnerabilities and updating many dependencies to latest versions, could you please give it another try and see if this is still happening?

Additionally, we rely on libphonenumber which is a phone numbers validation library. We could be getting false negatives for valid numbers. If you still get the alert messages, could you try validating the numbers in this page https://libphonenumber.appspot.com/ please?

danohn commented 3 years ago

@jefftcarroll can you check if you had a blank line on the bottom of your file?

danohn commented 3 years ago

This issue seems to happen if either one or both conditions are met:

  1. The file has an extra blank line at the bottom
  2. The file encoding is set to CRLF

I can recreate the issue if either conditions are met. Changing the file encoding to LF instead of CRLF and making sure there is no extra line at the bottom will resolve the issue.