fix(app): dialer hooks refactor

twilio / twilio-voice-react-native-app

Other

37 stars 21 forks source link

fix(app): dialer hooks refactor #44

Closed mhuynh5757 closed 1 year ago

mhuynh5757 commented 1 year ago

Fix some of the UX of the Dialer screen and refactor the hook logic.

Contributing to Twilio

All third-party contributors acknowledge that any contributions they provide will be made under the same open-source license that the open-source project is provided under.

[x] I acknowledge that all my contributions will be made under the project's license.

mhuynh5757 commented 1 year ago

Tested on Android emulator.

charliesantos commented 1 year ago

Fix some of the UX of the Dialer screen and refactor the hook logic.

Can you please provide more details?

What are the UX that you're trying to fix?
Why do you need to refactor the hook logic?
Which jira is this tied to?

mhuynh5757 commented 1 year ago

@kpchoy can chime in a bit here, but one of the buttons wasn't being enabled/disabled properly. The hook logic refactor isn't strictly necessary but some of the UX logic was in the component instead of the hook and I moved it and saw the opportunity to adjust the hook as a whole. The functional logic is the same, just organized better. There is no JIRA for this ticket, it came out of a conversation between me and Kevin. Probably should have made a ticket to stay on scope but it was a fast fix.

kpchoy commented 1 year ago

@charliesantos There is a small bug with this ticket: https://issues.corp.twilio.com/browse/VBLOCKS-1494 . I forgot to test the client dialer. And the call button is disabled since I only checked that the number field was not empty. The rest is @mhuynh5757 refactoring the hooks. Not all related to the error caused by my ticket.