twilio / twilio-voice-react-native-app

Other
37 stars 21 forks source link

[VBLOCKS-1379] Incoming call screen hooks and actions #58

Closed mhuynh5757 closed 1 year ago

mhuynh5757 commented 1 year ago

Submission Checklist

Description

Refactor and modify application state to allow for Incoming Calls.

Breakdown

Validation

Additional Notes

Note that without the incoming call components, the incoming call hooks and actions are only testable via unit tests. Manual testing of the incoming call feature end-to-end will come later.

Contributing to Twilio

All third-party contributors acknowledge that any contributions they provide will be made under the same open-source license that the open-source project is provided under.

mhuynh5757 commented 1 year ago

Live review notes:

Edit: decided not to do the CallInvite changes

mhuynh5757 commented 1 year ago

Update: tested existing functionality to ensure no regressions.

charliesantos commented 1 year ago

Update: tested existing functionality to ensure no regressions.

@mhuynh5757 as discussed, since there are no breaking changes and it's a large PR, please submit this to the main branch to avoid conflicts.

mhuynh5757 commented 1 year ago

Rebased onto main.

charliesantos commented 1 year ago

Reviewed the checklist. +1!