Closed mhuynh5757 closed 1 year ago
@mhuynh5757 can you please attach some screenshots for each UI state for both platforms?
@mhuynh5757 do we have figma link handy?
@mhuynh5757 , can we get our Android and iOS members to verify the behavior? Android feels correct to me, but iOS seems odd. Looking at the iOS phone app, it should allow us to select earpiece properly even with bluetooth device connected.
Submission Checklist
CHANGELOG.md
reflects any feature, bug fixes, or known issues made in the source codeFiles changed
tab was made prior to submitting the pull request ensuring the style guide was followedDescription
This PR implements the store actions and components for proper audio device selection during a call.
Breakdown
Validation
Additional Notes
Figma link: https://www.figma.com/file/IFiFQzWEp1xyM2nuqJCkC2/2022-Q2-React-Voice-SDK?type=design&node-id=629-19201&mode=design&t=xDdnuaT6Fub1wU2Y-0
iPhone - Earpiece selected (no bluetooth device connected to iPhone at all)
iPhone - Speaker selected (with or without bluetooth device connected to iPhone)
iPhone - Bluetooth selected (with bluetooth device connected to iPhone)
Android - Earpiece selected
Android - Speaker selected
Note: unable to select earpiece on iPhone when bluetooth device is connected. Is this an iOS limitation? I can select the speaker when there is a bluetooth device, but not earpiece. Calling
.select()
on the earpiece will have the native layer do something and report an audio devices changed event, but the selected device is still bluetooth in that event and indeed the bluetooth device is still relaying audio.Contributing to Twilio