twilio / twilio-voice-react-native

Other
62 stars 22 forks source link

[VBLOCKS-2900] Remove CallMessage type enums #377

Closed mhuynh5757 closed 3 weeks ago

mhuynh5757 commented 3 weeks ago

Submission Checklist

All third-party contributors acknowledge that any contributions they provide will be made under the same open-source license that the open-source project is provided under.

Description

This PR removes the CallMessage type (contentType and messageType) enums from the SDK. This PR also upgrades the native SDK version dependencies.

Breakdown

Validation

Additional Notes

N/A

dipankadas commented 3 weeks ago

@mhuynh5757

  1. The iOS SDK says Currently the only supported type is "application/json", which is also the default value. Are we enforcing this in RN SDK (If no string is provided, the set it to "application/json")?
  2. Also we have this in the iOS CL, To send a user defined message with the [TVOCall sendMessage:] or the [TVOCallInvite sendMessage:] method, set the "messageType" to "user-defined-message". Can we add the same here?
mhuynh5757 commented 3 weeks ago

I'll add the docstring requested changes, but I think long term we should just link to a Twilio Docs page that includes this information: https://twilio-engineering.atlassian.net/browse/VBLOCKS-3130?atlOrigin=eyJpIjoiMjM0MWVlMDJjNjBlNDBhZmEzZmVlOGE4YWEyZGIwYTgiLCJwIjoiaiJ9