twilio / twilio-voice-react-native

Other
72 stars 27 forks source link

[VBLOCKS-3134] Refactor callmessage classes #381

Closed mhuynh5757 closed 2 months ago

mhuynh5757 commented 3 months ago

Submission Checklist

All third-party contributors acknowledge that any contributions they provide will be made under the same open-source license that the open-source project is provided under.

Description

This PR refactors the CallMessage classes to simplify the API for sending call messages. Instead of having the customer construct an ephemeral call message class, we just have the customer pass in an interface representing the call message. This PR also utilizes the inheritdoc feature of TSDocs to prevent documentation duplication.

Breakdown

Validation

Scenario iOS Android
Send a valid message Success Success
Send a large message Fail - No callback, neither sent or failure, known issue Success - error shown
Send an invalid content type Success - No error, by design Success - No error, by design
Send an invalid message type Success - error shown Success - error shown

Additional Notes

N/A