VBLOCKS-2929 VBLOCKS-2927 Manual reconnection API - Githubissues

twilio / twilio-voice.js

Twilio's JavaScript Voice SDK

Other

52 stars 53 forks source link

VBLOCKS-2929 VBLOCKS-2927 Manual reconnection API #253

Closed charliesantos closed 5 months ago

charliesantos commented 5 months ago

Contributing to Twilio

All third party contributors acknowledge that any contributions they provide will be made under the same open source license that the open source project is provided under.

[x] I acknowledge that all my contributions will be made under the project's license.

Pull Request Details

See https://docs.google.com/document/d/1QMwkNXlJYSANksP0BrlJ_JAbJA86x85ZKKQ8656GnUw/edit#heading=h.woffqrxm0odm

// TODO (different tickets)

changelog
tests

Burndown

Before review

[ ] Updated CHANGELOG.md if necessary
[ ] Added unit tests if necessary
[x] Updated affected documentation
[ ] Verified locally with npm test
[x] Manually sanity tested running locally
[x] Ready for review

Before merge

[ ] Got one or more +1s
[ ] Squashed erroneous commits if necessary
[ ] Re-tested if necessary

charliesantos commented 5 months ago

looks like lint is failing

I was planning on on fixing the build in a different ticket, once all changes for chrome extension mv3 support are in. I put tests in the TODO assuming linting was included :)