search

twilio / twilio-voice.js

Twilio's JavaScript Voice SDK
Other
50 stars 52 forks source link

[BUG] Support node LTS #60

Closed dcustodio closed 2 years ago

dcustodio commented 2 years ago

As I was trying to install the @twilio/voice-sdk I got the following error:

error @twilio/voice-sdk@2.1.0: The engine "node" is incompatible with this module. Expected version "12". Got "16.6.2"

It would be nice if this package would work with the latest node LTS (v16).

Keep up the good work!

lanlin commented 2 years ago 
error @twilio/voice-sdk@2.1.0: The engine "node" is incompatible with this module. Expected version "12". Got "17.2.0"
lanlin commented 2 years ago 
 @twilio/voice-sdk > @twilio/audioplayer > babel-runtime > core-js@2.6.12: core-js@<3.4 is no longer maintained and not recommended for usage due to the number of issues. Because of the V8 engine whims, feature detection in old core-js versions could cause a slowdown up to 100x even if nothing is polyfilled. Please, upgrade your dependencies to the actual version of core-j
vekerdyb commented 2 years ago

This seems like a regression as v2.0.1 installs fine on my version of node (14), but v2.1.0 does not.

theWebKeyGuy commented 2 years ago

I would also appreciate it if this was updated to the latest node as soon as possible so we can complete our project.

benmccallum commented 2 years ago

+1, yarn info @twilio/voice-sdk shows (for v2.1.0) engines: { node: '12' },, so only v12 is allowed 😞

yarn info @twilio/voice-sdk@2.0.1 doesn't show any engines restriction, so I guess we're stuck with it for now. I'm guessing the 2.1 release meant to say node >= 12.

(node v12 reaches EOL in a couple of months https://nodejs.org/en/about/releases/)

jaymdq commented 2 years ago

Is there any ETA for this fix?

ryan-rowland commented 2 years ago

We've added an internal ticket for this and I aim to start processing it this week. Thanks for bringing this up and pinging us again!

vekerdyb commented 2 years ago

Thanks for merging the fix @ryan-rowland! Do you know when it can be released as a new version on NPM?

ryan-rowland commented 2 years ago

I'm re-opening this issue for visibility until the fix actually makes it into the release -- sorry about that. Expecting the release early next week.

vekerdyb commented 2 years ago

Hey @ryan-rowland sorry for keep pushing for this, but do you have an idea when this would be released? Thanks!

laurel-taylor commented 2 years ago

Also wondering if this is still slated for release soon. Node 12 EOL is coming up 😬 thanks!

benmccallum commented 2 years ago

Issue should be renamed [BUG] ... as per the tag. Might help it get the attention it needs.

dcustodio commented 2 years ago

The version 2.1.1 is already published and fixes this issue.