search

twilio / twilio-webchat-react-app

Twilio Webchat React App is an application that demonstrates a website chat widget built with Twilio's Conversations JS SDK, Twilio Paste Design library and Create React App.
MIT License
64 stars 71 forks source link

Sonarcloud integration #48

Closed mdeshpande12 closed 1 year ago

mdeshpande12 commented 1 year ago

This PR includes:

  1. Initial SonarCloud integration as part of Circle CI

Contributing to Twilio

All third-party contributors acknowledge that any contributions they provide will be made under the same open-source license that the open-source project is provided under.

mdeshpande12 commented 1 year ago

@mdeshpande12 How are we passing branchname to sonar?

@vinesh-kumar So from what I understand. In Sonarcloud, in order to setup branch-analysis for a particular branch; the config YAML file (with the build step of Sonarcloud scan) should be present in that branch. Internally, Sonarcloud will pick the branchname. Hence, we won't have to send it explicitly.

https://docs.sonarcloud.io/enriching/branch-analysis-setup/

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication