search

twilio / video-quickstart-android

Twilio Video Quickstart for Android
MIT License
213 stars 160 forks source link

AudioSink Compatibility with Custom AudioDevice #736

Closed cyodrew closed 1 year ago

cyodrew commented 1 year ago

Before filing an issue please check that the issue is not already addressed by the following:

Please ensure that you are not sharing any Personally Identifiable Information(PII) or sensitive account information (API keys, credentials, etc.) when reporting an issue.

Description

Adding an AudioSink on an AudioTrack does not seem to work when using a custom AudioDevice. By default, the DefaultAudioDevice is used by the system if one isn't specified and AudioSink callback works as expected. Are these features not compatible?

Steps to Reproduce

  1. Create an AudioDevice and add it to the Room prior to connecting via Video.setAudioDevice
  2. Add an AudioSink to an AudioTrack
  3. Observe that the callback renderSample is not invoked after connecting to the Room.

Code

This can be recreated by adding an AudioSink to the example custom audio device project.

Expected Behavior

The renderSample callback is invoked.

Actual Behavior

The renderSample callback is not invoked.

Reproduces how Often

100%

Logs

N/A

Versions

N/A

Video Android SDK

7.3.1

Android API

33

Android Device

Pixel 7 Pro

afalls-twilio commented 1 year ago

Thank you for the detailed bug report. We are in the midst of a significant release (upgrading webrtc) and as soon as that is complete we will verify if this is still an issue. Feel free to verify yourself upon the release.

ocarevs commented 1 year ago

Hi @cyodrew the issue is fixed with the Video Android SDK 7.6.1, works as expected and callbacks from the AudioSink are invoked when using custom AudioDevice. cc @afalls-twilio