twilio / video-quickstart-ios

Twilio Video Quickstart for iOS
https://www.twilio.com/docs/api/video
MIT License
457 stars 177 forks source link

Issue: Video Call with Accept and Reject at other user #147

Closed Nik20112 closed 3 years ago

Nik20112 commented 7 years ago

Hi, I want to know that is it possible to accept/reject option to other user for accept/reject the video call which is calling by user? Because I have downloaded the demo but there is not this feature available. How can I do it to develop this feature? Please give me suggestion or help.

Thanks Nikunj

paynerc commented 7 years ago

Hey Nikunj,

The Twilio Video product doesn't contain the concepts of placing calls directly. The approach for the Video product is that you have the concepts of rooms and people can join those rooms.

From there, you can build on a solution that uses Twilio Notify to invite other folks to join your room. We don't have a Quickstart for iOS yet that demonstrates this, but there is an Android Quickstart that does this.

Take a look at that and see if that doesn't get you moving in the right direction.

Thanks!

Ryan

Nik20112 commented 7 years ago

Hi, Thanks for your feedback. Using Twilio Notify, When I send notification other user, is it available with accept and reject option via push notification? Please let me know.

ceaglest commented 7 years ago

Hi Nikunj,

Hopefully I can help clarify things a little here. The Android / Twilio Notify example implements one half of the Invite experience. Imagine Alice wants to invite Bob to a video call.

  1. Alice and Bob register for push notifications.
  2. Alice sends a push notification to Bob inviting him to a Room.
  3. Alice joins the Room contained in the notification.
  4. If Bob accepts, Bob joins the same Room.
  5. Alice and Bob are in a video call.

As far as I understand the Android example does not signal from Bob back to Alice. So, if Bob were to reject the call (by not joining the Room) then Alice wouldn't know about it. In order to support rejecting a call you would need to send an additional notification from Bob back to Alice indicating the acceptance or decline of the Invite.

I'm trying to fill in for Ryan here as I happened to be online. Both Ryan and I are out of the office on Monday but I believe @ptankTwilio can help you out further if you have any more questions. Hopefully I have not mis-characterized the behavior of the Android example, but again more team members should be available to clarify on Monday.

Thank you, Chris Eagleston

ceaglest commented 7 years ago

Hi @Nik20112,

I'm bringing the discussion into your original ticket. We will do our best to integrate push notifications into our QS CallKit example in the future. However, if this is blocking you from getting started now I would suggest that you take a look at the Android example. The server side component is the same regardless of wether you use iOS or Android as the client (just replace FCM with APNS as the notification system).

Android Example: https://github.com/twilio/video-quickstart-android/tree/master/exampleVideoInvite

Server Side Examples: https://github.com/TwilioDevEd/sdk-starter-java https://github.com/TwilioDevEd/sdk-starter-php https://github.com/TwilioDevEd/sdk-starter-ruby https://github.com/TwilioDevEd/sdk-starter-node https://github.com/TwilioDevEd/sdk-starter-python

You will need to use one of these to make API calls to Twilio Notify.

Regards, Chris Eagleston

piyushtank commented 6 years ago

Hi @Nik20112 ,

Let us know if you are running into any issue while using Twilio SDKs to achieve the used case of Accept/Reject the video call.

Thanks, Piyush

iDarshn commented 6 years ago

Hi,

How can I add user to existing call using twilio voiceAPI?

Please let me know @ptankTwilio

jishindev commented 5 years ago

Hey @ceaglest, @piyushtank . How can we show a call screen like WhatsApp/Skype/Telegram etc even when the app is killed or/and the device is locked? Any suggestions on achieving that with Twilio notify?

piyushtank commented 5 years ago

@jishindev Yes Twilio Notify can solve the problem. When your app is killed, and if iOS receives a push notification when app is killed or in backgroun suspended, iOS will wake your app up. Upon receiving the push notification in your app, in push notification handler, you may want to connect to a Room.

Let me know if you have any questions.

jishindev commented 5 years ago

Thanks @piyushtank for the response. How about doing the same on android? Does the app wake up happen there as well? Any sample app source you could point me to?

piyushtank commented 5 years ago

@jishindev Everyone from our Android team is on vacation at the moment, they will be back next week. My best guess is the behavior would be similar in Android too, but I can check with our Android team when they are back and let you know.

aaalaniz commented 5 years ago

Hey @jishindev

Yes, the behavior is similar on Android. In the quickstart example that uses Notify your application will be informed of a push notification (even if your app is killed ) via a subclass of FirebaseMessagingService. The example shows a notification and sends a local broadcast, but you could implement any logic required in the onMessage callback.

Let me know if I need to clarify anything. Thanks!

sathishvgs commented 5 years ago

Hi @aaalaniz @piyushtank , Already, we have tried with Firebase Push Notification service. So, my doubt is what is the advantage of using Twilio Notify over the Firebase Push Notification. If we really have any new features we will migrate from Firebase Push Notification to Twilio Notify.

Thanks, Sathish Kumar G

sathishvgs commented 5 years ago

Hi @aaalaniz @piyushtank , Already, we have tried with Firebase Push Notification service. So, my doubt is what is the advantage of using Twilio Notify over the Firebase Push Notification. If we really have any new features we will migrate from Firebase Push Notification to Twilio Notify.

Thanks, Sathish Kumar G

Hi @aaalaniz @piyushtank , Can anyone check it out this because we have to implement on our end.

piyushtank commented 5 years ago

@sathishvgs Myself and Aaron we work in Voice and Video SDK team. I have reached out to our notify team to help you out. I will get back to you once I heard back from notify which should tomorrow. But in the meantime, I would recommend going over the notify-documentation to go over the the feature set notify provides. Thanks.

jishindev commented 5 years ago

Hey @aaalaniz, we've implemented the twilio notify on our app but having delay in getting video notification on Android 9 devices. Any clue why this would be happening?

piyushtank commented 5 years ago

@sathishvgs if you are using only the Firebase push notifications for making and receiving calls, you may not see additional benefit if you move to Twilio Notify per the TwilioNotify team, however we recommend Twilio Notify for signaling on top of Video SDK. Let me know if you have any more questions

sathishvgs commented 5 years ago

@piyushtank Thanks for the info.

dVp007 commented 3 years ago

Hi Nikunj,

Hopefully I can help clarify things a little here. The Android / Twilio Notify example implements one half of the Invite experience. Imagine Alice wants to invite Bob to a video call.

  1. Alice and Bob register for push notifications.
  2. Alice sends a push notification to Bob inviting him to a Room.
  3. Alice joins the Room contained in the notification.
  4. If Bob accepts, Bob joins the same Room.
  5. Alice and Bob are in a video call.

As far as I understand the Android example does not signal from Bob back to Alice. So, if Bob were to reject the call (by not joining the Room) then Alice wouldn't know about it. In order to support rejecting a call you would need to send an additional notification from Bob back to Alice indicating the acceptance or decline of the Invite.

I'm trying to fill in for Ryan here as I happened to be online. Both Ryan and I are out of the office on Monday but I believe @ptankTwilio can help you out further if you have any more questions. Hopefully I have not mis-characterized the behavior of the Android example, but again more team members should be available to clarify on Monday.

Thank you, Chris Eagleston

hey can we do the same thing in web app ? how to push notification on web app?

pwndhull commented 1 year ago

HI, i have an issue when i send try to a video call and other user accept the call just after that call automatically gets rejected. this one is specific issue or just a case with me?

Please help me with this.