twilio / video-quickstart-ios

Twilio Video Quickstart for iOS
https://www.twilio.com/docs/api/video
MIT License
465 stars 178 forks source link

Echo cancellation does not work on iPad Pro 12.9" (2017) #241

Closed piyushtank closed 6 years ago

piyushtank commented 6 years ago

Description

Echo Cancellation does not work properly on the iPad Pro 12.9" (2017).

Steps to Reproduce

  1. Alice joins a Room on iPad Pro 12.9" (2017).
  2. Bob joins the Room from his iPhone
  3. When Bob speaks, he can hear himself.

Expected Behavior

Bob should not get an echo when he speaks.

Actual Behavior

Bob gets an echo when he speaks.

Reproduces How Often

100%

iOS Version

iOS 11.3 Beta3 and prior

iOS Device

iPad Pro 12.9" (2017) only

piyushtank commented 6 years ago

This problem is not reproducible on iOS 11.3 Beta5.

ceaglest commented 6 years ago

Hello,

One workaround for this device specific bug is to use software echo cancellation. At the moment our iOS builds don't expose this feature, and we rely solely on Apple's AudioUnit echo cancellation solution. We are considering adding software echo cancellation to our iOS SDK, but we are also pleased that Apple has resolved the problem in their forthcoming iOS 11.3 update.

Regards, Chris

ceaglest commented 6 years ago

Closing now that iOS 11.3 has been available for some time. We don't have any near term plans to add a software echo cancellation option, but we are considering doing this post 2.0.

malavagile commented 5 years ago

Hello @ceaglest ,

I am facing the same issue currently which @piyushtank raised previously.

I have just updated my Twillio iOS SDK Version to 2.7 but still, I am able to hear my self.

I have check out that there is an option to enable software cancellation from localAudioTrack but somehow I am not able to set those options. Can you check it out and let me know where I am going wrong.

I couldn't find a way to enable it.

I tried to use the class directly and with a wrapper class as well.

I have tested it with iOS 12.1.4 on iPhone 6S Plus and iPhone X.

screenshot 2019-02-26 at 3 07 12 pm