search

twilio / video-quickstart-ios

Twilio Video Quickstart for iOS
https://www.twilio.com/docs/api/video
MIT License
465 stars 178 forks source link

ISDK-2749: VideoTracks might not be rendered in QS example. #442

Closed ceaglest closed 4 years ago

ceaglest commented 4 years ago

This PR addresses https://github.com/twilio/video-quickstart-ios/issues/384, where a RemoteVideoTrack might not be rendered. The specific sequence of events that is problematic is when unsubscribing to the old VideoTrack happens after the new VideoTrack is subscribed.

As I looked more closely at the code there were other issues (like some RemoteParticipants not having a delegate). I tried to make the event handling dynamic and flexible so that any time there is remote video to render, the example will attempt to render it instead of sitting idle.

Contributing to Twilio

All third-party contributors acknowledge that any contributions they provide will be made under the same open-source license that the open-source project is provided under.

ceaglest commented 4 years ago

I have not applied the changes to VideoCallKitQuickStart yet. If we agree I can port them over there as well.

ceaglest commented 4 years ago

@paynerc thanks for your review. I have now ported the changes to VideoCallKitQuickStart.