twilio / video-quickstart-ios

Twilio Video Quickstart for iOS
https://www.twilio.com/docs/api/video
MIT License
465 stars 178 forks source link

ISDK-2863, ISDK-2355, ISDK-2903: Update ReplayKitExample for 3.4.0, improve video quality #503

Closed ceaglest closed 3 years ago

ceaglest commented 4 years ago

This PR makes several changes to improve the quality of ReplayKit content.

Also, subscriber / viewer functionality has been added

TODO

Contributing to Twilio

All third-party contributors acknowledge that any contributions they provide will be made under the same open-source license that the open-source project is provided under.

ceaglest commented 4 years ago

I have noticed that there are some layout issues on the iPhone X related to insets on the collection view, and zooming the scroll view. It might need a little more effort to fix, but this PR is ready for a look.

ceaglest commented 4 years ago

Screen recording of the app UI showing most of the new features:

RPReplay_Final1591925997.MP4.zip

ceaglest commented 4 years ago

What do you think about showing two buttons in home page : Presenter, Viewer. When user clicks on presenter - we give them option to use In-App Vs extension ?

I like that, it would be a lot cleaner than 3 large buttons. Otherwise we should just use a TableView with each option.

Do you think it is worth adding Viewer code in the sample app? Maintaining the UI will be painful. We can refer to the VideoApp if needed.

I think we should add a viewer UI. It offers the ability to pinch, zoom and scroll and demonstrates how to use bandwidth profile + publish for this use case. Not having a viewer experience is a source of confusion for the example app and the default QS does a bad job in this role.

ceaglest commented 3 years ago

Closing this PR since 4.0 has dedicated classes for ReplayKit functionality. The example will be updated to use the SDK APIs to access ReplayKit.