twilio / video-quickstart-js

A quickstart and code samples for Twilio Video JavaScript SDK. https://www.twilio.com/docs/video
Other
389 stars 337 forks source link

VIDEO-3563 Small patch to fix audio level indicator #171

Closed PikaJoyce closed 3 years ago

PikaJoyce commented 3 years ago

JIRA Ticket : VIDEO-3563

This is a small patch to the audio level indicator breaking on iOS safari. The fix is now we are passing in the audio track rather than the stream so we can access the new media stream from the track that was restarted when silence is detected.

image

Please refer to the JIRA ticket of the working fix.

There are some caveats to this fix, if a user decided to close and open the tab multiple times (3+) the indicator will break. However, this is a corner case that should not happen under normal circumstances.

Contributing to Twilio

All third-party contributors acknowledge that any contributions they provide will be made under the same open-source license that the open-source project is provided under.