search

twilsonco / latexdiffcite

latexdiffcite is a wrapper around latexdiff to make citations diff properly
BSD 2-Clause "Simplified" License
26 stars 9 forks source link

Fix crash when no authors present #11

Closed twilsonco closed 5 years ago

twilsonco commented 5 years ago

Updated make_author_year_tokens_from_bib() so that bib items that don't have authors (e.g. books with editor lists) are still handled correctly. Also moved some re.compile() calls outside the loop for efficiency.

Sidenote: I'd be happy to become a regular contributor to this project.

cmeeren commented 5 years ago

Thanks! If you want to take over ownership of this project, I'd be very happy. I haven't used this for many years, will likely never do so again, and don't have the capacity to support it.

If you want to take over, let me know your PyPI username and I'll transfer the package as well as this repo to you.

twilsonco commented 5 years ago

Sure thing. I’ve got a string of papers and a thesis to write, so I’ll make good use in that time.

My PyPI username is twilsonco.

Thanks,

Tim On Jul 15, 2019, 9:46 AM -0600, Christer van der Meeren notifications@github.com, wrote:

Thanks! If you want to take over ownership of this project, I'd be very happy. I haven't used this for many years, will likely never do so again, and don't have the capacity to support it. If you want to take over, let me know your PyPI username and I'll transfer the package as well as this repo to you. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

cmeeren commented 5 years ago

It seems you have to delete your fork in order for me to transfer ownership of this repo to you.

Also, I've made you an owner of the PyPI package, but I can't remove myself. Please remove me as a package owner when you can. :)

twilsonco commented 5 years ago

Hi Christer,

I’ve deleted my fork of latexdiffcite on GitHub.

Thanks,

Tim On Jul 16, 2019, 2:13 AM -0600, Christer van der Meeren notifications@github.com, wrote:

It seems you have to delete your fork in order for me to transfer ownership of this repo to you. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

cmeeren commented 5 years ago

There you go. Thanks, and good luck!

twilsonco commented 5 years ago

Am I the owner of the repo now? I've never done this before. Seems I still don't have write access (can't upload files).

Edit: Ah, there was another email. Seems the transfer worked. Thanks for the tool. I'll keep it working in the interim.

cmeeren commented 5 years ago

I think you have to approve the transfer on your end first. Don't know how it works.

cmeeren commented 5 years ago

Ah, great. Thanks!