search

twindle-co / twindle

Twindle - an open source project for beginners. Converting twitter threads to pdf, epub, and mobi format to be read by Kindle.
https://www.twindle.co
MIT License
134 stars 133 forks source link

Jest test cases #709

Closed Proful closed 3 years ago

PuruVJ commented 3 years ago

@johnjacobkenny has already set some up, we'll get through to the end with this

Proful commented 3 years ago

@PuruVJ we need 80-90% test coverage. As this is extremely important, I count on you to take responsibility.

PuruVJ commented 3 years ago

I'll try. But first, I'll have to learn testing 😂

johnjacobkenny commented 3 years ago

It should be too easy for you @PuruVJ :partying_face:

PuruVJ commented 3 years ago

@johnjacobkenny Thanks for the confidence Kenny. Though I've never done any testing before, Imma do it right for this

Proful commented 3 years ago

@PuruVJ any updates?

PuruVJ commented 3 years ago

Already working on a feature/test branch

PuruVJ commented 3 years ago

I'm seriously gonna need help on this. I've never done testing before. I have learned the concepts, but have no idea how to start on twindle. I have set up some basic tests, but dunno how to cover every case.

johnjacobkenny commented 3 years ago

Cover what you can, others will pitch in

Proful commented 3 years ago

keep adding few test cases at a time.

don't close this ticket. we will close this ticket once we have good % of testing

PuruVJ commented 3 years ago

This issue is too broad. Should be closed and replaced with smaller and more specific issues, like Github testing, Twitter testing, HN testing, and with a solid, tangible goal in mind(Optional in beginning, and should be added). Progress should be documented there, by referencing the PRs doing this work.