Sync recent changes

[PuruVJ]

Description

• Remove smtp-client module and file (Unnecessary. Correct me if its needed, will add it back)
• Modify the tedious format(new Date(tweet.created_at), 'MMM d, yyyy') to be as simple as formatTimestamp(tweets.created_at)
• Modify the utils test to account for this new change. All tests passing

Attach Screenshot

[PuruVJ]

Can somebody help me all the above commits tagging along?

I don't know how to get rid of these

[johnjacobkenny]

Can somebody help me all the above commits tagging along?

I don't know how to get rid of these

Lol

[PuruVJ]

What do you think Kenny? Looks good enough?

[Mira-Alf]

Looks good to me. There is twitter-puppeteer/index.js and Twitter/scraping/index. Js. Which one is being used??

[PuruVJ]

@Mira-Alf I've set up the scraping one as the default in my upcoming commit.

[PuruVJ]

Right now its twitter-puppeteer

[Mira-Alf]

Either way we ll need to get rid of one. We can discuss it during the evening call. Also down the road we don't need the puppeteer flag because the application should do scraping only if tweet is older than 7 days.

[johnjacobkenny]

@Mira-Alf I've set up the scraping one as the default in my upcoming commit.

Will wait before merging

[PuruVJ]

@johnjacobkenny Now you can merge it.

[PuruVJ]

If you can merge, I'll start looking into how to resolve that Jest error about token.

[Proful]

Please do not go wild and add typescript everywhere.

Typescript is not beginner friendly.

[johnjacobkenny]

@PuruVJ I'm not sure if you committed the typings folder

[PuruVJ]

We are not adding typescript in most of the places. We're editing only in JS files only. Only those familiar with TS files need to update the file.

There is no extra dependency introduced.

Beginners still need to code in javascript and there is no need to learn typescript.

@PuruVJ reduced the tone of your comments.

[johnjacobkenny]

Please do not go wild and add typescript everywhere.

Typescript is not beginner friendly.

@proful I think in this case it may be transparent to anyone using it, since he has added a few typings files which is silently there. But it adds value for the dev experience

[Proful]

That's fine. Just sharing my thoughts for future.

[johnjacobkenny]

@PuruVJ I'm not sure if you committed the typings folder

@PuruVJ will merge after your confirmation

[PuruVJ]

Committed

[PuruVJ]

Issue with keeping it in typings folder.

[johnjacobkenny]

Could you now merge into main with the changes? After that you can look at the tests