CLI Rendering link issue - preview image not displaying

twindle-co / twindle

Twindle - an open source project for beginners. Converting twitter threads to pdf, epub, and mobi format to be read by Kindle.

https://www.twindle.co

MIT License

134 stars 133 forks source link

CLI Rendering link issue - preview image not displaying #723

Closed Proful closed 3 years ago

Proful commented 3 years ago

node . -p -i 1312742534221832192 Example Thread

PuruVJ commented 3 years ago

Can you send the link of that thread?

PuruVJ commented 3 years ago

This problem hasn't been solved yet. @twindle-co/developer please take a look at this.

Answer lies in rich-rendering.js, in the function renderOutsiderLinks. Someone fix it up to not show the box if no link is returned from twitter data

shekhar10feb commented 3 years ago

I am working on it.

PuruVJ commented 3 years ago

How's the progress going Shekhar?

Proful commented 3 years ago

@all-contributors please add @shekhar10feb for twindle

allcontributors[bot] commented 3 years ago

@proful

I couldn't determine any contributions to add, did you specify any contributions? Please make sure to use valid contribution names.

Proful commented 3 years ago

@all-contributors please add @shekhar10feb for code

allcontributors[bot] commented 3 years ago

@proful

I've put up a pull request to add @shekhar10feb! :tada: