Twitter 7daysold switchscraping

twindle-co / twindle

Twindle - an open source project for beginners. Converting twitter threads to pdf, epub, and mobi format to be read by Kindle.

https://www.twindle.co

MIT License

134 stars 133 forks source link

Twitter 7daysold switchscraping #727

Closed Mira-Alf closed 3 years ago

Mira-Alf commented 3 years ago

Description

Switch to scraping logic if Tweet is older than 7 days
The number of tweets on a thread in the common information on the pdf was incorrectly displayed as 1 - this was fixed

Attach Screenshot

Note 2 code reviewer approval needed. Approach in twitter group & discord channel.

PuruVJ commented 3 years ago

@Mira-Alf I'm thinking it would be better to throw the errors, and catch them. the code you've pushed relies on the error that is returned along with the data.

I've made some modifications on my end that catch the error(rather than read the returned error). This decreases the surface area for bugs, make the code more elegent and idiomatic.

Are you OK if I propose those changes(catching rather than reading them)? I'll port the above code to use it.

Mira-Alf commented 3 years ago

Not sure I understand what exactly you mean. But go ahead and make the changes - I will take a look at it once your change is in place.