search

twindle-co / twindle

Twindle - an open source project for beginners. Converting twitter threads to pdf, epub, and mobi format to be read by Kindle.
https://www.twindle.co
MIT License
134 stars 133 forks source link

Move test checking to Github Actions #735

Closed PuruVJ closed 3 years ago

PuruVJ commented 3 years ago

Right now, tests are run when any commit is made, locally and globally. This is undesirable, as sometimes we need to switch branches to see some code. For that we need to commit the code. This code is very unstable and simply not ready. Git husky simply doesn't allow to commit these if tests are breaking(which they definitely are, cuz the code is simply not ready). This is very inconvenient.

I recommend we move the test checking to Github Actions to check for every PR.

cc @johnjacobkenny

johnjacobkenny commented 3 years ago

Yeah I added an action and removed husky. See if that suits our requirement.