twindle-co / twindle

Twindle - an open source project for beginners. Converting twitter threads to pdf, epub, and mobi format to be read by Kindle.
https://www.twindle.co
MIT License
134 stars 133 forks source link

Changes in epub.js #736

Closed shekhar10feb closed 3 years ago

shekhar10feb commented 3 years ago

Description

Some changes in epub.js

Attach Screenshot

epubjs

Note 2 code reviewer approval needed. Approach in twitter group & discord channel.

johnjacobkenny commented 3 years ago

Could you explain what all you have changed and how to run the code

shekhar10feb commented 3 years ago

Could you explain what all you have changed and how to run the code

Instead of using tweets, created a format, used mock data for using twit-thread.json(will create) but I was stuck on how to create htmlContent and options and passing options variable as argument in new Epub as Tolga suggested.

github-actions[bot] commented 3 years ago

This pull request has conflicts, which you need to resolve! :partying_face: Don't need to worry at all, please follow the steps here - https://github.com/twindle-co/twindle/wiki/Resolving-merge-conflicts

johnjacobkenny commented 3 years ago

@tolgaerdonmez could you help out

tolgaerdonmez commented 3 years ago

ons variable as argument in new Epub as Tolga sug

image

So here I added the generateEpub function and gave the tweets and outputPath created in the index.js

image

Here is the generateEpub function, which uses the newly created tweets

shekhar10feb commented 3 years ago

ons variable as argument in new Epub as Tolga sug

image

So here I added the generateEpub function and gave the tweets and outputPath created in the index.js

image

Here is the generateEpub function, which uses the newly created tweets

Thank you Kenny and Tolga

johnjacobkenny commented 3 years ago

@shekhar10feb I think the epub changes have been made by @tolgaerdonmez already? If yes, please close this and raise a PR just for the article you have written

shekhar10feb commented 3 years ago

@shekhar10feb I think the epub changes have been made by @tolgaerdonmez already? If yes, please close this and raise a PR just for the article you have written

Ok