Feature/epub generation

twindle-co / twindle

Twindle - an open source project for beginners. Converting twitter threads to pdf, epub, and mobi format to be read by Kindle.

https://www.twindle.co

MIT License

134 stars 133 forks source link

Closed tolgaerdonmez closed 3 years ago

tolgaerdonmez commented 3 years ago

Note 2 code reviewer approval needed. Approach in twitter group & discord channel.

tolgaerdonmez commented 3 years ago

@PuruVJ @proful I hope it is okay now

PuruVJ commented 3 years ago

this looks good. Can be merged

A question though. We have set up prettier config, and according to it, the indentations should only 2 spaces, but your code has 4 of those.

Can you check if you have the prettier config in the package.json? Send a screenshot.

Proful commented 3 years ago

Good catch @PuruVJ

@tolgaerdonmez please format as per prettier configuration defined in package.json

PuruVJ commented 3 years ago

Here's the .prettierrc file. Paste it in twindle folder, so we can have equal formatting everywhere.

{
  "trailingComma": "es5",
  "tabWidth": 2,
  "semi": true,
  "singleQuote": false,
  "printWidth": 100,
  "arrowParens": "always"
}

Proful commented 3 years ago

@PuruVJ why this is needed?

We already have this configuration in package.json

@johnjacobkenny

tolgaerdonmez commented 3 years ago

@PuruVJ why this is needed?

We already have this configuration in package.json

@johnjacobkenny

vscode don't recognize the package.json prettier config I believe and it would be better to see it alone :)

Proful commented 3 years ago

It does for me.

You may have to try some settings