search

twindle-co / twindle

Twindle - an open source project for beginners. Converting twitter threads to pdf, epub, and mobi format to be read by Kindle.
https://www.twindle.co
MIT License
134 stars 133 forks source link

CLI epub the download message should be displayed on DEV=true #748

Closed Proful closed 3 years ago

Proful commented 3 years ago

image

tolgaerdonmez commented 3 years ago

There is an option called verbose in the package, and it defaults to false but still it prints the logs. I tried setting it manually totrue & false but always prints the logs.

PuruVJ commented 3 years ago

Anyone working on this @twindle-co/developer ?

tolgaerdonmez commented 3 years ago

The problem with this is the epub-gen module, like you've said the package is a bit broken with the option verbose I'll send a issue but they're not active

Mira-Alf commented 3 years ago

Also I noticed some other problems with this regard - when one of the images is not available for download or there is an error while downloading, then the entire epub file gets corrupted. These are issues with the epub-gen NodeJS module

PuruVJ commented 3 years ago

I think we need to implement our own algo to download images and replace the src attribute with data: path

tolgaerdonmez commented 3 years ago

I think we need to implement our own algo to download images and replace the src attribute with data: path

After the svelte components are done, it can be easily handled by our components in svelte

PuruVJ commented 3 years ago

This issue is too broad. Closing it in favour of a new issue regarding encoding images.