twindle-co / twindle

Twindle - an open source project for beginners. Converting twitter threads to pdf, epub, and mobi format to be read by Kindle.
https://www.twindle.co
MIT License
134 stars 133 forks source link

CLI Edge cases Not able to read thread properly #758

Closed Proful closed 3 years ago

Proful commented 3 years ago

https://twitter.com/b0rk/status/1326162989335064578

node . -i 1326162989335064578

madhusudanbabar commented 3 years ago

I'll try this.

madhusudanbabar commented 3 years ago

I'm facing some troubles now

I tried to create the thread manually and tested on my own thread here is the link https://twitter.com/MadhusudanBabar/status/1326484312108249088 Screenshot (117)

but I'm getting the error TypeError: Cannot read property '0' of undefined

can anyone confirm with this tweet id 1326484312108249088 or here is the URL https://twitter.com/MadhusudanBabar/status/1326484312108249088

none of these ID's is working 1326484308014534656, 1326484312108249088, 1326484310052966401 and if I go with the puppeteer option then there's another error Screenshot (119)

Proful commented 3 years ago

@johnjacobkenny @PurUVJ @Mira-Alf can anyone help @madhusudanbabar

PuruVJ commented 3 years ago

I'm facing some troubles now

I tried to create the thread manually and tested on my own thread here is the link https://twitter.com/MadhusudanBabar/status/1326484312108249088 Screenshot (117)

but I'm getting the error TypeError: Cannot read property '0' of undefined

can anyone confirm with this tweet id 1326484312108249088 or here is the URL https://twitter.com/MadhusudanBabar/status/1326484312108249088

none of these ID's is working 1326484308014534656, 1326484312108249088, 1326484310052966401 and if I go with the puppeteer option then there's another error Screenshot (119)

These issues are happening b'coz there's a deleted tweet there. haven't tested for those yet.

Proful commented 3 years ago

@madhusudanbabar can you please check this if it is deleted tweets skip that specific tweet.

madhusudanbabar commented 3 years ago

@madhusudanbabar can you please check this if it is deleted tweets skip that specific tweet.

Just one tweet from that thread was deleted,

But when i visit with the URL this tweet is available, the IDs mentioned here are not deleted, i deleted the different one

You can verify with twitter.com/MadhusudanBabar/status/ID

madhusudanbabar commented 3 years ago

this is not a proper solution but I found another way to get it, by means of the referenced tweet's id from the expansions and then getting the contents of that tweet id and repeating the same process until there are no referenced tweets, but this actually goes in reverse order, means we need to check for the id of the last tweet and from that, we traverse back to the first tweet.

here is the screenshot, the tweets are in last to first order twindle_tweets

Proful commented 3 years ago

Very good analysis @madhusudanbabar

@PuruVJ and @Mira-Alf any comments?

Mira-Alf commented 3 years ago

I studied this issue really hard. Here is the problem explained in my words

First Tweet of the thread

image

Direct Reply 1

image

Direct Reply 2

image

johnjacobkenny commented 3 years ago

Is there a way for you to filter the first level or replies based on time? Will it work if we pick the older first reply?

PuruVJ commented 3 years ago

@Mira-Alf is this issue fixed?

PuruVJ commented 3 years ago

This is worth while, but not focusing on this for some time