Fix for Bug #823 and for issue #773 - Githubissues

twindle-co / twindle

Twindle - an open source project for beginners. Converting twitter threads to pdf, epub, and mobi format to be read by Kindle.

https://www.twindle.co

MIT License

134 stars 133 forks source link

Fix for Bug #823 and for issue #773 #834

Closed Mira-Alf closed 3 years ago

Mira-Alf commented 3 years ago

Fix for issue #823

The error was in epub generation module and not in tweets generation
PDF was generating correctly for the same set of threads

Fix for issue #773

This fix was discussed during today's call between @PuruVJ, @johnjacobkenny and me - decided to remove created_at attribute from regular tweets on threads and simply add that piece of info to user timeline tweets
Template was modified to display the date if it is available
Further testing might be needed to make sure that this fix didnt break anything else

Other things done in this PR

The user timeline did not fetch tweets that other users mentioned. This has been fixed - now only replies to other users and retweets on the user timeline are being hidden

Things to do:

Put each thread in a try catch block - if any errors skip the thread and go to the next one with an error message for that thread - this can be more complicated - we are thinking a try catch block with contiue in catch block - but puru said he will think some more.

Attach Screenshot

Note 2 code reviewer approval needed. Approach in twitter group & discord channel.