search

twindle-co / twindle

Twindle - an open source project for beginners. Converting twitter threads to pdf, epub, and mobi format to be read by Kindle.
https://www.twindle.co
MIT License
134 stars 133 forks source link

CLI github output to A5 size #855

Closed Proful closed 3 years ago

Proful commented 3 years ago
PuruVJ commented 3 years ago

It is A5 size already. Larger font - That can be done. how much larger? Current font size is 108%, or 17.28px. What do you think

Proful commented 3 years ago

@PuruVJ are you talking about github md pdf?

PuruVJ commented 3 years ago

No.

There's a github md pdf too?

Please update the title to indicate the fact it's related to Github Rendering Pipeline

PuruVJ commented 3 years ago

Is it resolved?

Proful commented 3 years ago

it is looking good in Kindle. Doesn't look like A4.

PuruVJ commented 3 years ago

I still think we should at least experiment in A5 a little.

What can go wrong, only change needed of 2 letters 😁

Mira-Alf commented 3 years ago

I dont understand this issue. The PDF is being rendered in A5 format already right? await page.pdf({ path: outputPath, format: "A5", margin: { bottom: 52, // minimum required for footer msg to display left: 20, right: 20, top: 10, }, printBackground: true, displayHeaderFooter: true, footerTemplate: footerMarkup(), headerTemplate: "<div></div>", });

I see the above code and the format is clearly A5. Am I missing something?