search

twindle-co / twindle

Twindle - an open source project for beginners. Converting twitter threads to pdf, epub, and mobi format to be read by Kindle.
https://www.twindle.co
MIT License
134 stars 133 forks source link

Added function calculateFileNameForGitHub #885

Closed shekhar10feb closed 3 years ago

shekhar10feb commented 3 years ago

Description

Added calculateFileNameForGitHub function with date format as suggested by Proful in the issue #880

Attach Screenshot

Note 2 code reviewer approval needed. Approach in twitter group & discord channel.

Proful commented 3 years ago

@PuruVJ and @Mira-Alf please review

@shekhar10feb please clean up the commit history.

https://github.com/twindle-co/twindle/blob/main/docs/articles/solving-branch-ahead-of-upstream.md

PuruVJ commented 3 years ago

@shekhar10feb I don't think you should apply the commit cleanup code in the article for this PR, as your changes might get deleted. Just take care for future commits