search

twindle-co / twindle

Twindle - an open source project for beginners. Converting twitter threads to pdf, epub, and mobi format to be read by Kindle.
https://www.twindle.co
MIT License
134 stars 133 forks source link

Change in naming convention of file generated via GitHub MD #890

Closed SarveshKadam closed 3 years ago

SarveshKadam commented 3 years ago

Currently, we are using the naming conventions

<GitHub Username>-<Repository Name>-<CLI Run Date>.pdf

For eg. : kentcdodds-react-fundamentals-Dec-5-2020.pdf

This will give an error if you want to fetch another .md file from the same repository on the same day and also it will override your existing file.

Here's my suggested filename

<GitHub Username>-<Repository Name>-<MD File name>-<CLI Run Date>.pdf

For eg. : kentcdodds-react-fundamentals-01-Dec-5-2020.pdf

Mira-Alf commented 3 years ago

@sarvesh this was a good catch, I am now extracting the file name along with branch and repo details - so using that to compute file name as you have described it here image

Closing this issue.