twindle-cli runtime error

twindle-co / twindle

Twindle - an open source project for beginners. Converting twitter threads to pdf, epub, and mobi format to be read by Kindle.

https://www.twindle.co

MIT License

134 stars 133 forks source link

twindle-cli runtime error #946

Closed harshulvijay closed 3 years ago

harshulvijay commented 3 years ago

Command used:

node . -i 1337875532483092480 -o test

PuruVJ commented 3 years ago

This is the result of my attempt to merge stuff from renderer-svelte to main

Mira-Alf commented 3 years ago

Sure, I will take a look at this.

Mira-Alf commented 3 years ago

This is not an issue because of the svelte changes. This is a unique error happening in a special circumstance. We need to discuss on how to handle this. Here is the tweet id: Tweet link

The tweet is a reply to another user and consequently not the first tweet of the thread
Code tries to locate the first tweet of the thread but the first tweet has not been made by the same user - consequently it returns undefined
Since the lookup fails - it is unable to find/search other tweets on the same thread
What should be done in this case? ThreadReader app simply states this is a reply and cannot be rolled. Should we take a similar approach or tweak the logic to print the original post and the reply?

PuruVJ commented 3 years ago

ThreadReader app simply states this is a reply and cannot be rolled. Should we take a similar approach or tweak the logic to print the original post and the reply?

The first part seems good enough.

Did you try some other tweet?

Proful commented 3 years ago

@all-contributors please add @Mira-Alf for code, mentoring

allcontributors[bot] commented 3 years ago

@proful

I've put up a pull request to add @Mira-Alf! :tada:

Proful commented 3 years ago

@all-contributors please add @tolgaerdonmez for code, mentoring

allcontributors[bot] commented 3 years ago

@proful

I've put up a pull request to add @tolgaerdonmez! :tada:

PuruVJ commented 3 years ago

Making this another issue for now.