Closed tr0mbl3y closed 3 years ago
@all-contributors please add @tr0mbl3y for code
@proful
I've put up a pull request to add @tr0mbl3y! :tada:
@tr0mbl3y the problem is that the Mozilla reader view renders the above websites the same way which is what we use, so our output looks exactly the same way. If we need to fix this, we need to look at their source code to fix what they are doing or use a different application underneath. If anyone else has any other ideas, we can try it out
@Mira-Alf alright then this is not an issue anymore! but do check for case 3: like in first picture i am not getting full contents
@tr0mbl3y these are some interesting cases. Case 3 happened because the content is hidden behind a paywall. Cases 1 and 2 are a little strange but the Mozilla reader renders the content this way as well and they use the @mozilla-readability npm module. So there will need to be either tweaks for these kind of cases or we must use a different npm module altogether. I think we can close this issue for now.
alright closing this then!
:case 1
: case 2
websites i tried on: https://www.nytimes.com/interactive/2020/health/moderna-covid-19-vaccine.html : case 1 https://www.wsj.com/articles/tech-giants-face-new-rules-in-europe-backed-by-huge-fines-11608046500 : case 3 https://www.nytimes.com/live/2020/12/18/world/covid-19-coronavirus : case 2
linkin' with other issues related to redability #949