search

twinformatics / eureka-consul-adapter

This project contains a Spring Boot Starter that registers HTTP endpoints on a Spring Cloud Eureka server to support Prometheus's service discovery mechanism for Consul (<consul_sd_config>)
MIT License
103 stars 35 forks source link

Add consul health endpoint #25

Closed avaneev95 closed 4 years ago

avaneev95 commented 4 years ago

This PR contains an implementation of the consul health endpoint /v1/health/service for Prometheus v2.17.0. Closes #24

tine2k commented 4 years ago

Thank you very much for your contribution, @avaneev95. I'll look into this within the next days.

rmie commented 4 years ago

I tested it briefly, and it seems like eureka metadata labels are now published differently:

__meta_consul_metadata_* => __meta_consul_service_metadata_*
avaneev95 commented 4 years ago

@rmie It's correct behaviour for v1.3.0 when eurekaConsulAdapter.useNodeMeta is not set or set to false. See #16

rmie commented 4 years ago

@avaneev95 thanks for clarification, indeed that's what I was missing

tine2k commented 4 years ago

Just released this as 1.4.0 on Central. Thank you both for your help.