search

twinformatics / eureka-consul-adapter

This project contains a Spring Boot Starter that registers HTTP endpoints on a Spring Cloud Eureka server to support Prometheus's service discovery mechanism for Consul (<consul_sd_config>)
MIT License
102 stars 35 forks source link

Updated to support Spring Boot 2 and Spring Cloud Finchley #6

Closed barrycommins closed 6 years ago

barrycommins commented 6 years ago

First off, this is a really useful project, thanks for creating it. I've been using it for a while now, and it has worked perfectly.

I was just testing it out with Spring Boot 2 and Spring Cloud Finchley.RELEASE, and noticed that the /v1/catalog/ endpoints were not working.

Some minor pom updates were all that were required to get it working. See: https://stackoverflow.com/questions/42748775/spring-webflux-and-observable-responses-not-working

org.springframework.cloud.netflix.rx.SingleReturnValueHandler is no longer present in Spring Cloud Netflix, but it doesn't seem to be required when using rxjava-reactive-streams.

Any suggestions for changes, please let me know.

ghost commented 6 years ago

thanks for your contribution, barry! sorry, I couldnt respond sooner (vacation). I will test/review this in the coming days.

ghost commented 6 years ago

@barrycommins merged and released as 1.0.0. Thanks again for your help.