Open dentarg opened 8 years ago
I've heard that https://github.com/ruby-amqp/march_hare is worth looking at when running JRuby. Bunny might work if we limit to JRuby 9000 though (https://github.com/ruby-amqp/bunny#supported-ruby-versions).
I was thinking that Twingly::AMQP could be smart, on JRuby, use March Hare, on CRuby, use Bunny. But maybe that's too much work, not possible, or just a bad idea?
I was thinking that Twingly::AMQP could be smart, on JRuby, use March Hare, on CRuby, use Bunny. But maybe that's too much work, not possible, or just a bad idea?
I think that's what is required and probably a good idea. We might need to tweak our abstraction a bit to make everything fit beneath it, but we should at least look at it. We should probably wait until our first JRuby project has proven itself worthy.
We should probably wait until our first JRuby project has proven itself worthy.
Yes, that sounds reasonable.
Re: Bunny and JRuby
18 days ago, https://github.com/ruby-amqp/bunny/issues/356#issuecomment-146463167
Thank you but JRuby is no longer supported.
We should start with using march_hare in a project and then extract that code if it fits here.
Might be interesting to read for inspiration: https://github.com/travis-ci/travis-amqp/tree/master/lib/travis/amqp
18 days ago, ruby-amqp/bunny#356 (comment)
Thank you but JRuby is no longer supported.
Bunny now works with JRuby: https://github.com/ruby-amqp/bunny/pull/529, though march_hare is still probably a better alternative.
Bunny now works with JRuby: ruby-amqp/bunny#529, though march_hare is still probably a better alternative.
We need to require at least 2.7.3 in our gemspec.
I tried publishing, using twingly-amqp under JRuby. Seems to work.
I think we could do the things necessary to at least support JRuby "on the paper". It ought to be just to require some minimum version of Bunny.
We're about to introduce JRuby in a project, and wouldn't it be cool if we could just use Twingly::AMQP over there? ;-)
Also, when we have JRuby in place, I think there will be more projects that what to "hop on the train".