search

twingly / twingly-amqp

:bus: Ruby gem for RabbitMQ subscribing and publishing
0 stars 0 forks source link

Set expiration per ping #37

Closed roback closed 8 years ago

roback commented 8 years ago

RabbitMQ cannot change queue-length and queue-message-ttl, the queue has to be deleted and then redeclared. We wanted to be able to change this value easily, so we had to use per-message-ttl instead.

This is needed for the queue between norrstrom and klondike.

see https://trello.com/c/Setqn4Fd

jage commented 8 years ago

LGTM!

dentarg commented 8 years ago

Instead of having "ms" in comments, couldn't it be part of the attribute name? ping_expiration_in_ms?

walro commented 8 years ago

Instead of having "ms" in comments, couldn't it be part of the attribute name? ping_expiration_in_ms?

That will become a breaking change now. :D

roback commented 8 years ago

Instead of having "ms" in comments, couldn't it be part of the attribute name? ping_expiration_in_ms?

Yes, that would have worked, but its too late now :P

dentarg commented 8 years ago

It's never too late.