search

twingly / twingly-amqp

:bus: Ruby gem for RabbitMQ subscribing and publishing
0 stars 0 forks source link

Non-blocking subscribe (#on_each_message) #61

Closed roback closed 7 years ago

roback commented 7 years ago

I didn't want to duplicate all tests from #each_message, so I just copied the one I felt was most important (the one that makes sure it can receive a message from rabbitmq).

close #29

walro commented 7 years ago

have you considered it to be the one and same method and blocking is provided as a parameter (possibly to initialize)? Similar to how Bunny works that is.

roback commented 7 years ago

have you considered it to be the one and same method and blocking is provided as a parameter (possibly to initialize)? Similar to how Bunny works that is.

I have not. That would be more clear to the user of this gem what is happening. each_message(blocking: true) is more intention revealing than on_each_message.