search

twingly / twingly-amqp

:bus: Ruby gem for RabbitMQ subscribing and publishing
0 stars 0 forks source link

Set connection instance as default argument #94

Closed walro closed 3 years ago

walro commented 3 years ago

I can't see the point of the pattern that was there before, at least.

walro commented 3 years ago

I have a vague memory that we have talked about this before, but I have no idea what the reason was for using nil this way, so LGTM!

Same :D Let's find out in 2 years when whatever it is bites us

roback commented 3 years ago

Too bad the committer didn't write a good message: https://github.com/twingly/twingly-amqp/commit/0d2219bf79d5f41fd48eb5ef2e3f6986c07cc718

...and a master commit too 🙈