Closed Chrizpy closed 4 years ago
Oh, possibly we want to bump faraday_middleware
too
Perhaps we should do something about
while at it. I.e. allowing faraday >= 1.0. IIRC you must get to >= 1.0 to get rid of all 2.7 warnings.
Code breaks when I bump it up to >= 1.0, gonna investigate 🤔
We should also release a new version of the twingly-http
gem, as per the instructions at https://github.com/twingly/twingly-http#release-workflow
I think just bumping the patch version is enough for the changes made here.
I got a mail it's released, but change log is not updated?
See: 49081a730e060884a5b5e6723a24a7834cc71abd :)
Perhaps we should do something about https://github.com/twingly/twingly-http/blob/d5dc1f6482c7825310c0d446ffc3f9ec88927c73/twingly-http.gemspec#L17 while at it. I.e. allowing faraday >= 1.0.
IIRC you must get to >= 1.0 to get rid of all 2.7 warnings.