search

twingly / twingly-http

Robust HTTP client
https://rubygems.org/gems/twingly-http
MIT License
0 stars 1 forks source link

Require `"logger"` #23

Closed Pontus4 closed 3 years ago

Pontus4 commented 3 years ago

Got the following error in https://github.com/twingly/basil/pull/78:

gems/twingly-http-0.3.1/lib/twingly/http.rb:66:in `default_logger': uninitialized constant Twingly::HTTP::Client::Logger (NameError)

This bug was introduced in #13.

walro commented 3 years ago

Hehe, so specs happened to pass due to:

Would be cool to catch this in the specs, but likely not worth the effort to get that going.

walro commented 3 years ago

Consider yanking 0.3.0 and 0.3.1 :)

roback commented 3 years ago

Would be cool to catch this in the specs, but likely not worth the effort to get that going.

Had the same thought, but couldn't come up with any reasonable way to test this :)

Pontus4 commented 3 years ago

0.3.2 released and 0.3.0 and 0.3.1 yanked 🎉