search

twingly / twingly-search-api-java

:coffee: Twingly Blog Search API in Java
https://developer.twingly.com/resources/search/
3 stars 7 forks source link

Introduced QueryBuilder approach #14

Closed xSAVIKx closed 8 years ago

xSAVIKx commented 8 years ago

refactored Query and Client classes, so that now: API key, base URL and search path are now related to Client. Query object is now just holder for search pattern and related parameters (start and end time, document language) Introduced QueryBuilder that follows Builder pattern and should be used for Query object creation. refactored all related to changes unit tests rewritten examples to use new approach refactored README to compile successfully in IDEA and to follow changes

twingly-mob commented 8 years ago

Slightly off-topic question, we are curious on https://github.com/twingly/twingly-search-api-java/pull/14/files#diff-04c6e90faac2675aa89e2176d2eec7d8R56 what does it do? It seems like it builds a jar file, but we can't find the key embedded in it. Where should we find the key?

xSAVIKx commented 8 years ago

Slightly off-topic question, we are curious on https://github.com/twingly/twingly-search-api-java/pull/14/files#diff-04c6e90faac2675aa89e2176d2eec7d8R56 what does it do? It seems like it builds a jar file, but we can't find the key embedded in it. Where should we find the key?

It's just an example how key should be passed to any jvm-based program. Maybe, it'll be more clear, if the example will be smth like: java -jar myJar.jar -DTWINGLY_SEARCH_KEY=some_key_value

twingly-mob commented 8 years ago

It's just an example how key should be passed to any jvm-based program. Maybe, it'll be more clear, if the example will be smth like: java -jar myJar.jar -DTWINGLY_SEARCH_KEY=some_key_value

Yes, that's clearer.

xSAVIKx commented 8 years ago

@twingly-mob I've updated documentation with new example.

dentarg commented 8 years ago

@xSAVIKx great work, we will take a last quick look tomorrow, I think we will be happy :)