Update Java client to Search API v3

twingly / twingly-search-api-java

:coffee: Twingly Blog Search API in Java

https://developer.twingly.com/resources/search/

3 stars 7 forks source link

Update Java client to Search API v3 #30

Closed xSAVIKx closed 7 years ago

xSAVIKx commented 7 years ago

I've updated the Java client to the latest v3 API.

What was done:

dependencies versions were bumped to the latest ones
gradle version was bumped to the latest one
added .gitattribute in order to be sure that files have correct line endings on commits
updated the overall client classes to work with v3 API - can close #29.
added support for compression - can close #28.

dentarg commented 7 years ago

Hi @xSAVIKx

This is not a proper review from me, I just have some questions. @roback will review, hopefully later this week.

disable openJDK build as it fails with sigfaults

Care to elaborate on this? Do you know the reason to as it sigfaults (did you mean "segfault"?)? Does the old version have the same problem with openjdk7?

Do we really need a .gitattributes that long for this repo?

Thanks!

xSAVIKx commented 7 years ago

@dentarg Yes, misprint - segfault. I do not know the reason and actually not willing to dig into the OpenJDK. It was introduced just as an option and I don't think anyone should invest time into making it work on Travis OpenJDK.

As for the .gitattributes - it's just a generated boilerplate for any possible project. If you do want - I can clean it up.

dentarg commented 7 years ago

Yes, please cleanup .gitattributes

xSAVIKx commented 7 years ago

@roback @dentarg Please review updates.

I've made client more backward-compatible - almost same changes as for the Python client.

yuri-sergiichuk commented 7 years ago

Hi @roback, how it is going?

roback commented 7 years ago

Hi @roback, how it is going?

Unfortunately we have a few other things that has higher priority that we need to finish first, so I won't be able to continue with this at the moment. Sorry for keeping you waiting.

roback commented 7 years ago

Tested the coordinates and it worked great 👍

I will merge this now.