twingly / twingly-search-api-ruby

:gem: Twingly Blog Search API in Ruby
https://developer.twingly.com/
MIT License
4 stars 0 forks source link

Wrap lines at 72 characters #2

Closed dentarg closed 10 years ago

dentarg commented 10 years ago

parser.rb, post.rb and result.rb all have lines exceeding 72 characters. Makes them hard to read.

jage commented 10 years ago

Why 72? I'd prefer if we used 80 as the maximum characters per line.

dentarg commented 10 years ago

To have some margin.

At the end of the typewriter age, most designs were geared toward 72 CPL, derived from a pitch of 12 characters per inch, multiplied by 6 inches (see for example IBM Selectric). This would ensure at least 1 inch for each margin, with the U.S. government at the time having standardized on 8 1/2×11" paper. Early computer text editors used this measure as a baseline for their terminal interfaces. – Wikipedia

78 is also ok, this is how it looks:

screen shot 2013-10-21 at 08 53 40

dentarg commented 10 years ago

But maybe it's a bit extreme (and dated) to have the limit at 72/78/80 nowadays?

At http://richarddingwall.name/2008/05/31/is-the-80-character-line-limit-still-relevant/ there's a discussion about that.

jage commented 10 years ago

I think it's a good convention to try and keep the lines at 80, sometimes It's ok to have longer but they should be exceptions.

I don't like 72 or 78 for code. Most terminals and editors have 80 as default. (80 comes from the IBM punchcards). Most lines are much shorter than 72, so it's only margin for the longer lines. If we were writing manual pages och "plain text" documentation I can understand the 72/78 argument.

jage commented 10 years ago

We should define this in a Tailor config and use it for all projects. To enforce it. https://github.com/turboladen/tailor

dentarg commented 10 years ago

OK, 80 it is.

jage commented 10 years ago

Fixed in 558eef5ea89b240315727c9df2c958008f59a3a7