search

twingly / twingly-search-api-ruby

:gem: Twingly Blog Search API in Ruby
https://developer.twingly.com/
MIT License
4 stars 0 forks source link

Handle non-XML responses from server #33

Closed roback closed 8 years ago

roback commented 8 years ago

Decided to handle non-XML responses inside the parser (instead of in the client) since all other errors are handled there.

fix #31

jage commented 8 years ago

Nice! How about creating a private method that takes the data_node and returns a Result object? It would separate the error handling code from the Result creation.

roback commented 8 years ago

How about creating a private method that takes the data_node and returns a Result object? It would separate the error handling code from the Result creation.

:+1: Good idea :)

jage commented 8 years ago

LGTM!