search

twingly / twingly-search-api-ruby

:gem: Twingly Blog Search API in Ruby
https://developer.twingly.com/
MIT License
4 stars 0 forks source link

endpoint_url is unused #39

Closed walro closed 8 years ago

walro commented 8 years ago

https://github.com/twingly/twingly-search-api-ruby/blob/72cec57ae11a1f865f9044d7bf1c7de38a2cb147/lib/twingly/search/client.rb#L52-L53

jage commented 8 years ago

Isn't it used in https://github.com/twingly/twingly-search-api-ruby/blob/72cec57ae11a1f865f9044d7bf1c7de38a2cb147/lib/twingly/search/query.rb#L27?

walro commented 8 years ago

Yeah, I noticed that when starting to remove things. I wonder what I did wrong when searching though....

However, the dependency is quite strange, isn't it? It's not used by the class itself, but other classes rely on it.

walro commented 8 years ago

Yeah, I noticed that when starting to remove things. I wonder what I did wrong when searching though....

Ah, I only searched /spec, forgot that I had that there... :)

walro commented 8 years ago

However, the dependency is quite strange, isn't it? It's not used by the class itself, but other classes rely on it.

I'll let that slide :)