twingly / twingly-search-api-ruby

:gem: Twingly Blog Search API in Ruby
https://developer.twingly.com/
MIT License
4 stars 0 forks source link

rack-2.0.1 requires ruby version >= 2.2.2, which is incompatible with the current version #58

Closed dentarg closed 8 years ago

dentarg commented 8 years ago

Tests fail for all versions except 2.3.0: https://travis-ci.org/twingly/twingly-search-api-ruby/builds/159866314

E.g. 1.9.3: https://travis-ci.org/twingly/twingly-search-api-ruby/jobs/159866315

$ gem update bundler
Updating installed gems
Updating bundler
Fetching: bundler-1.13.1.gem (100%)
Successfully installed bundler-1.13.1
Gems updated: bundler
13.09s$ bundle install --jobs=3 --retry=3 --path=${BUNDLE_PATH:-vendor/bundle}
Fetching gem metadata from https://rubygems.org/...........
Fetching version metadata from https://rubygems.org/..
Fetching dependency metadata from https://rubygems.org/.
Resolving dependencies...
rack-2.0.1 requires ruby version >= 2.2.2, which is incompatible with the
current version, ruby 1.9.3p551

I guess we need to limit either webmock or vcr (development dependencies).

dentarg commented 8 years ago

Oh, it is github_changelog_generator -> github_api -> oauth2 -> rack

jage commented 8 years ago

Oh, it is github_changelog_generator -> github_api -> oauth2 -> rack

Couldn't we kick it out of the gemspec?

dentarg commented 8 years ago

I think we should remove github_changelog_generator from the gemspec... :)